Skip to content

Fix regrtest rerun: reset worker_bug - #162293

Merged
vstinner merged 1 commit into
python:mainfrom
vstinner:regrtest_worker_bug
Nov 19, 2026
Merged

vstinner merged 1 commit into
python:mainfrom
vstinner:regrtest_worker_bug

Conversation

@vstinner

Copy link
Copy Markdown
Member

When a test fails with "worker bug" and tests are rerun in verbose mode, reset worker_bug so that tests are marked as success if the failed test doesn't fail again when rerun in verbose mode.

TestResult.write_json_into(file) now calls also file.flush().

When a test fails with "worker bug" and tests are rerun in verbose
mode, reset worker_bug so that tests are marked as success if the
failed test doesn't fail again when rerun in verbose mode.

TestResult.write_json_into(file) now calls also file.flush().
@vstinner

Copy link
Copy Markdown
Member Author

RISC-V 64-bit Ubuntu Clang 3.x, build 787, https://buildbot.python.org/#/builders/2255/builds/787 failed with:

== Tests result: FAILURE, WORKER BUG then WORKER BUG ==

test_generator_stop failed with "worker bug", but then passed when rerun in verbose mode. This PR changes the result to:

== Tests result: FAILURE, WORKER BUG then SUCCESS ==


The worker bug:

test_generator_stop worker bug (Failed to parse worker process JSON: Expecting ':' delimiter: line 1 column 528 (char 527))

I don't know what triggered this bug. I added "TestResult.write_json_into(file) now calls also file.flush()" change: maybe the JSON contents was not flushed properly into the UNIX pipe?

@vstinner

Copy link
Copy Markdown
Member Author

Android (x86_64) failed: https://github.com/python/cpython/actions/runs/44620009832/job/135899016015?pr=162293

  Starting a Gradle Daemon (subsequent builds will be faster)
  
  FAILURE: Build failed with an exception.
  
  * What went wrong:
  A problem occurred configuring root project 'Python testbed'.
  > Could not resolve all artifacts for configuration 'classpath'.
     > Could not find org.jetbrains.kotlin:kotlin-stdlib:2.3.20.
       Searched in the following locations:
         - https://dl.google.com/dl/android/maven2/org/jetbrains/kotlin/kotlin-stdlib/2.3.20/kotlin-stdlib-2.3.20.pom
         - https://repo.maven.apache.org/maven2/org/jetbrains/kotlin/kotlin-stdlib/2.3.20/kotlin-stdlib-2.3.20.pom
         - https://plugins.gradle.org/m2/org/jetbrains/kotlin/kotlin-stdlib/2.3.20/kotlin-stdlib-2.3.20.pom
       Required by:
           buildscript of root project 'Python testbed'

I don't understand what's going on. I will just re-run the failed job.

@vstinner
vstinner merged commit f84083b into python:main Nov 19, 2026
108 of 109 checks passed
@vstinner
vstinner deleted the regrtest_worker_bug branch November 19, 2026 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant